[bug] - copy chunk before sending on chunksChan #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcastorina
approved these changes
Aug 16, 2023
dustin-decker
approved these changes
Aug 16, 2023
|
Added an integration test to keep me honest! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Memory Sharing Issues: I was sharing the chunk variable across iterations. When I update chunk.Data and send the pointer &chunk to the channel, all the chunks I was sending would point to the same memory. The change in one will affect all of them. If another goroutine is reading from the channel and modifying the chunk in parallel, we can run into concurrent read-write conflicts.
Create a new copy before passing it into the chunks chan.
Checklist:
make test-community)?make lintthis requires golangci-lint)?