Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating github templates #1587

Merged
merged 3 commits into from
Aug 1, 2023
Merged

updating github templates #1587

merged 3 commits into from
Aug 1, 2023

Conversation

zricethezav
Copy link
Collaborator

Description:

This PR updates some of the .github templates to make issue content a little more concise and adds a PR template. It also changes test-forks to test-community so contributors are encouraged to run make test-community locally -- sounds a little better than running make test-forks locally.

Open to suggestions on any/all of this

Checklist:

  • Does your PR pass tests (make test-community)?
  • Have you lint your code locally prior to submission (make lint this requires golangci-lint)?

@zricethezav zricethezav requested a review from a team as a code owner August 1, 2023 16:08
@zricethezav zricethezav added enhancement github_actions Pull requests that update GitHub Actions code labels Aug 1, 2023
Copy link
Collaborator

@mcastorina mcastorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking, just added a few thoughts.

.github/ISSUE_TEMPLATE/feature_request.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@zricethezav zricethezav merged commit b906a51 into main Aug 1, 2023
9 checks passed
@zricethezav zricethezav deleted the update-github-templates branch August 1, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement github_actions Pull requests that update GitHub Actions code
Development

Successfully merging this pull request may close these issues.

2 participants