Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create hidden debug flag to disable overseer #1582

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Conversation

zubairk14
Copy link
Contributor

@zubairk14 zubairk14 commented Jul 31, 2023

allows users to attach a debugger to a local trufflehog scanner

@zubairk14 zubairk14 requested a review from a team as a code owner July 31, 2023 18:00
@zubairk14 zubairk14 marked this pull request as draft July 31, 2023 18:00
@zubairk14 zubairk14 marked this pull request as ready for review July 31, 2023 19:19
Copy link
Collaborator

@rosecodym rosecodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great in goland! thanks!

main.go Outdated
@@ -38,6 +38,7 @@ var (
debug = cli.Flag("debug", "Run in debug mode.").Bool()
trace = cli.Flag("trace", "Run in trace mode.").Bool()
profile = cli.Flag("profile", "Enables profiling and sets a pprof and fgprof server on :18066.").Bool()
LocalDev = cli.Flag("local-dev", "Hidden feature to disable overseer for local dev.").Hidden().Bool()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional nitpick: Since this variable is only used in this file, we probably don't need to export it. So renaming to localDev would be good.

@zubairk14 zubairk14 merged commit a4b1fb7 into main Aug 1, 2023
8 of 9 checks passed
@zubairk14 zubairk14 deleted the disable-overseer branch August 1, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants