[chore] - Do not skip scanning commits if scanning comments errors #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ahrav
commented
Jul 30, 2023
ahrav
commented
- An error while scanning comments should not prevent us from scanning the repo. We should simply log the error and try to scan the repo.
|
oooh good idea - did you run into a situation where this was causing problems? |
zubairk14
changed the title
I was fixing a separate issue for a data race and then stumbled upon this. The actual chance where we are not able to scan comments should be really really low in practice, but figured i'd just update it while was poking around this part of the code. |
|
#1552 also partially addresses this by giving precedence to scanning the repo over the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.