implement indeterminate LDAP verification #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrav
approved these changes
Aug 1, 2023
mcastorina
approved these changes
Aug 2, 2023
pkg/detectors/ldap/ldap.go
Outdated
Comment on lines
68
to
72
| err := verifyLDAP(username[1], password[1], ldapURL) | ||
| s1.Verified = err == nil | ||
| if !isErrDeterminate(err) { | ||
| s1.VerificationError = err | ||
| } |
There was a problem hiding this comment.
Nit: The s1.Verified = err == nil looks weird, but I'm not sure this is better.
if err := verifyLDAP(username[1], password[1], ldapURL); err == nil {
s1.Verified = true
} else if !isErrDeterminate(err) {
s1.VerificationError = err
}It's technically different behavior since we don't explicitly set s1.Verified = false for the err != nil case.
rosecodym
force-pushed
the
tri-state-ldap
branch
from
88684d5
to
3749930
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements tri-state verification for the LDAP detector. This implementation looks for network errors to explicitly flag as indeterminate, rather than authentication errors to explicitly flag as determinate; this is because the error that occurs from authentication failures doesn't appear to have its own type and I didn't want to have to match on the error message text.