Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was discovered in the community slack channel when a npm token was not being detected. This was due to the fact that the existing ahocorasick library does not properly implement overlapping matches (see related issue here: petar-dambovaliev/aho-corasick#12).
To test this bug try running an unverified scan on the follow content:
You'll see it does not detect a secret. This is because
npm_
is currently taking precedence over thenpm
keyword due totrufflehog/pkg/engine/engine.go
Line 156 in 93c561f
StandardMatch
does not fix it even though the library says it should support overlapping matches.Testing this on a few example repos yields pretty similar performance results