Add SourceManager tests for Run and Wait methods #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Own the chunks channel instead of accepting it as an input * Add Chunks and Wait methods * Fix bug in Enroll so it actually returns the handle * Add context.Context parameter to the SourceInitFunc type
rosecodym
approved these changes
Jul 24, 2023
| @@ -77,16 +87,14 @@ func (s *SourceManager) Enroll(ctx context.Context, name string, kind sourcespb. | |||
| return 0, fmt.Errorf("handle ID '%d' already in use", handleID) | |||
| } | |||
| s.handles[handleID] = f | |||
| return 0, nil | |||
There was a problem hiding this comment.
Tests are great :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.