Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease frequency of dependabot alerts to monthly #1524

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Decrease frequency of dependabot alerts to monthly #1524

merged 2 commits into from
Jul 21, 2023

Conversation

zricethezav
Copy link
Collaborator

Title says it all. Automatically updating all go mod dependencies every week is too much

@zricethezav zricethezav requested a review from a team as a code owner July 21, 2023 14:24
rosecodym
rosecodym approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@rosecodym rosecodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I approve of this in spirit I don't know why the original frequency was picked so you should probably wait for the approval of someone who does :v

.github/dependabot.yml Outdated
@@ -8,9 +8,9 @@ updates:
- package-ecosystem: "gomod" # See documentation for possible values
directory: "/" # Location of package manifests
schedule:
interval: "weekly"
interval: "monthly"
- package-ecosystem: "github-actions"
directory: "/"
schedule:
# Check for updates to GitHub Actions every weekday
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update this comment too? Or better yet, delete it?

mcastorina
mcastorina approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@mcastorina mcastorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say for certain why a weekly cadence was chosen - I think it was one of those quality of life automations that Dustin setup to make sure our dependencies are up to date.

Monthly cadence is good for the amount of PRs it's generating now imo.

@zricethezav zricethezav merged commit be68eb0 into main Jul 21, 2023
10 checks passed
@zricethezav zricethezav deleted the decrease-depedabot branch July 21, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcastorina mcastorina mcastorina approved these changes

@rosecodym rosecodym rosecodym approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zricethezav @mcastorina @rosecodym