-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add role assumption for s3 source #1477
Conversation
user can pass array of roles to assume
use timestamp to make dynamic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just one more piece to wire up and an ineffectual assignment to clean up.
break s3 bucket scanning into sep. function
- Make sure s3 struct is populated with roles - add separate new client instantiation for role-based access - iterates through each role
@mcastorina @dustin-decker - This is ready for review. Some contextual notes and possible discussion points:
|
- separate functions for: - enumerating buckets to scan - scanning objects within the buckets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - nice work!
Adds assumeRole for AWS/S3 Source