fix: bump typescript and fix errors #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estrattonbailey
commented
Jul 5, 2023
| @@ -84,7 +84,7 @@ export function gretch<T = DefaultGretchResponse, A = DefaultGretchError>( | |||
| ...(rest as RequestInit), | |||
| }; | |||
| const controller = | |||
| typeof AbortController !== "undefined" ? new AbortController() : null; | |||
| typeof AbortController !== "undefined" ? new AbortController() : undefined; | |||
There was a problem hiding this comment.
TS didn't like an optional param (evals to Type | undefined) being potentially null
estrattonbailey
commented
Jul 5, 2023
Comment on lines
+107
to
+109
| ([] as GretchBeforeHook[]) | ||
| .concat(hooks.before) | ||
| .forEach((hook) => hook(request, opts)); |
There was a problem hiding this comment.
Just flattening an array and iterating over it
estrattonbailey
commented
Jul 5, 2023
Comment on lines
+4
to
+7
| attempts: number; | ||
| codes: number[]; | ||
| methods: string[]; | ||
| delay: number; |
There was a problem hiding this comment.
User options use Partial<RetryOptions>, and we merge in defaults, so the source type should be non-optionally typed.
estrattonbailey
requested review from
christianbundy,
manan30 and
wjohnson-truework
estrattonbailey
force-pushed
the
typescript-updates
branch
from
abc23ce
to
69dd940
Compare
manan30
approved these changes
Jul 6, 2023
christianbundy
approved these changes
Jul 12, 2023
wjohnson-truework
approved these changes
Jul 18, 2023
wjohnson-truework
suggested changes
Sep 15, 2023
wjohnson-truework
previously approved these changes
Sep 15, 2023
wjohnson-truework
dismissed
their stale review
Dismissing bc needs a version bump, but don't want to block with req changes
|
Hey sorry for the delay on these, my headspace has been taken up by my new job. Hope to get back to these soon! In the meantime obviously feel free to do as you wish with the library ✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just kicking the tires, minor stuff. This won't result in a package version bump.