This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Feat / home, create campaign end to end test #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for trompa-campaign-manager ready! Built with commit 360945e https://deploy-preview-12--trompa-campaign-manager.netlify.app |
RCVZ
changed the title
demmyhonore
approved these changes
Mar 9, 2021
…gn-manager into feat/e2e-home-create-campaign
…gn-manager into feat/e2e-home-create-campaign
royschut
reviewed
Mar 11, 2021
| @@ -38,6 +38,7 @@ exports[`<SelectComposition /> renders and matches snapshot 1`] = ` | |||
| </p> | |||
| <div> | |||
| <button | |||
| aria-label="select_composition" | |||
There was a problem hiding this comment.
We might prefer without underscore? Then it's also readable for screen readers.
…gn-manager into feat/e2e-home-create-campaign
royschut
reviewed
Mar 17, 2021
royschut
reviewed
Mar 17, 2021
royschut
reviewed
Mar 17, 2021
| const assert = require('assert'); | ||
| const { ariaLabel } = require('./locators'); | ||
| const { tolerance } = require('./settings'); | ||
|
|
There was a problem hiding this comment.
Minor: extra spaces before ariaLabel and tolerance
royschut
reviewed
Mar 17, 2021
royschut
reviewed
Mar 17, 2021
royschut
reviewed
Mar 17, 2021
royschut
suggested changes
Mar 17, 2021
royschut
approved these changes
Mar 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds: