Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for spherical advection in Cartesian coordinates #30

Merged
merged 6 commits into from
Sep 3, 2024

Conversation

tristanmontoya
Copy link
Member

@tristanmontoya tristanmontoya commented Aug 17, 2024

Addresses #28.

@tristanmontoya tristanmontoya changed the title Add tests for spherical advection in Cartesian coordinates Add test for spherical advection in Cartesian coordinates Aug 17, 2024
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (d8b0d31) to head (c53fcb9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #30       +/-   ##
===========================================
+ Coverage   50.90%   81.78%   +30.87%     
===========================================
  Files           8        8               
  Lines         827      829        +2     
===========================================
+ Hits          421      678      +257     
+ Misses        406      151      -255     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@amrueda amrueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!
Many thanks, @tristanmontoya !

@amrueda amrueda merged commit 15062dc into main Sep 3, 2024
10 checks passed
@amrueda amrueda deleted the tm/test_spherical_advection branch September 3, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants