Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Paired Explicit Runge-Kutta Integrator: Third Order #2008

Open
wants to merge 134 commits into
base: main
Choose a base branch
from

Conversation

warisa-r
Copy link
Contributor

@warisa-r warisa-r commented Jul 9, 2024

This PR introduces a new single-step paired explicit Runge-Kutta integrator of the third order. Along with this implementation, NLsolve has been added as a weak dependency.

Tests have been added for the example elixir_burgers_perk3.jl both with and without the fixed time step. Additionally, methods_PERK2.jl is also modified so that some functions can also be called by the third-order integrator.

Please feel free to let me know if there is anything that is missing or needs improvement!

warisa-r and others added 30 commits May 25, 2024 17:52
Co-authored-by: Daniel Doehring <[email protected]>
Co-authored-by: Daniel Doehring <[email protected]>
Co-authored-by: Daniel Doehring <[email protected]>
Co-authored-by: Daniel Doehring <[email protected]>
Co-authored-by: Daniel Doehring <[email protected]>
Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I left some comments and questions below.

ext/TrixiNLsolveExt.jl Outdated Show resolved Hide resolved
ext/TrixiNLsolveExt.jl Outdated Show resolved Hide resolved
ext/TrixiNLsolveExt.jl Outdated Show resolved Hide resolved
ext/TrixiNLsolveExt.jl Outdated Show resolved Hide resolved
ext/TrixiNLsolveExt.jl Show resolved Hide resolved
DanielDoehring
DanielDoehring previously approved these changes Aug 13, 2024
Copy link
Contributor

@DanielDoehring DanielDoehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @warisa-r !

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants