Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove interfaces and boundaries from cache_parabolic #1754

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Merge branch 'main' into jc/remove_cache_parabolic_interfaces

d93198d
Select commit
Loading
Failed to load commit list.
Draft

Remove interfaces and boundaries from cache_parabolic #1754

Merge branch 'main' into jc/remove_cache_parabolic_interfaces
d93198d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 3, 2024 in 0s

86.60% (-9.67%) compared to ad384c6

View this Pull Request on Codecov

86.60% (-9.67%) compared to ad384c6

Details

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (ad384c6) 96.27% compared to head (d93198d) 86.60%.

Files Patch % Lines
src/solvers/dgsem_tree/dg_1d_parabolic.jl 0.00% 20 Missing ⚠️
src/callbacks_step/amr_dg1d.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1754      +/-   ##
==========================================
- Coverage   96.27%   86.60%   -9.67%     
==========================================
  Files         438      438              
  Lines       35623    35609      -14     
==========================================
- Hits        34294    30836    -3458     
- Misses       1329     4773    +3444     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.