Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable save solution with time intervals for SimpleIntegratorSSP #1677

Merged
merged 17 commits into from
Dec 14, 2023

Conversation

amrueda
Copy link
Contributor

@amrueda amrueda commented Oct 19, 2023

This PR implements some modifications to SimpleIntegratorSSP, such that SaveSolutionCallback can be used with time intervals (keyword dt) instead of time-step intervals (keyword interval).

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

Project.toml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c7c4cf7) 94.67% compared to head (6ef243e) 96.23%.

Files Patch % Lines
src/time_integration/methods_SSP.jl 92.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1677      +/-   ##
==========================================
+ Coverage   94.67%   96.23%   +1.56%     
==========================================
  Files         436      436              
  Lines       35166    35210      +44     
==========================================
+ Hits        33292    33882     +590     
+ Misses       1874     1328     -546     
Flag Coverage Δ
unittests 96.23% <92.00%> (+1.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Project.toml Outdated Show resolved Hide resolved
src/time_integration/methods_SSP.jl Outdated Show resolved Hide resolved
src/time_integration/methods_SSP.jl Outdated Show resolved Hide resolved
@amrueda amrueda marked this pull request as draft October 23, 2023 09:40
@amrueda amrueda changed the title WIP: Enable save solution with time intervals for SimpleIntegratorSSP Enable save solution with time intervals for SimpleIntegratorSSP Dec 13, 2023
@amrueda amrueda marked this pull request as ready for review December 13, 2023 20:24
@amrueda amrueda requested a review from sloede December 14, 2023 08:31
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sloede sloede closed this Dec 14, 2023
@sloede sloede reopened this Dec 14, 2023
@ranocha ranocha enabled auto-merge (squash) December 14, 2023 11:07
@ranocha ranocha merged commit f191444 into trixi-framework:main Dec 14, 2023
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants