Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two-sided Zalesak-type IDP subcell limiting #1648

Merged
merged 35 commits into from
Nov 13, 2023

Merge branch 'main' into subcell-limiting-minmax

f7b8d0a
Select commit
Loading
Failed to load commit list.
Merged

Add two-sided Zalesak-type IDP subcell limiting #1648

Merge branch 'main' into subcell-limiting-minmax
f7b8d0a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 13, 2023 in 0s

86.65% (-9.58%) compared to 1b75f5e

View this Pull Request on Codecov

86.65% (-9.58%) compared to 1b75f5e

Details

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (1b75f5e) 96.23% compared to head (f7b8d0a) 86.65%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1648      +/-   ##
==========================================
- Coverage   96.23%   86.65%   -9.58%     
==========================================
  Files         425      428       +3     
  Lines       34253    34482     +229     
==========================================
- Hits        32960    29878    -3082     
- Misses       1293     4604    +3311     
Files Coverage Δ
.../elixir_euler_blast_wave_sc_subcell_nonperiodic.jl 100.00% <100.00%> (ø)
..._dgsem/elixir_euler_sedov_blast_wave_sc_subcell.jl 100.00% <100.00%> (ø)
...ee_2d_dgsem/elixir_euler_shockcapturing_subcell.jl 100.00% <ø> (ø)
...ulti_shock_bubble_shockcapturing_subcell_minmax.jl 100.00% <100.00%> (ø)
..._shock_bubble_shockcapturing_subcell_positivity.jl 100.00% <ø> (ø)
...tree_2d_dgsem/elixir_mhd_shockcapturing_subcell.jl 100.00% <ø> (ø)
src/solvers/dg.jl 91.87% <ø> (ø)
src/solvers/dgsem_tree/dg_2d_subcell_limiters.jl 99.57% <100.00%> (+0.01%) ⬆️
src/solvers/dgsem_tree/subcell_limiters.jl 90.20% <100.00%> (+4.90%) ⬆️
src/equations/equations.jl 96.55% <80.00%> (-1.56%) ⬇️
... and 3 more

... and 84 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.