Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding quasi 1d shallow water equations #1619
Adding quasi 1d shallow water equations #1619
Changes from 19 commits
f3f397f
a97dabd
b340a74
af25d90
5defbf6
c045570
09b2e4e
71fab3e
3362c04
09ec421
2d5c704
70c01ad
d4f58b8
d434e89
2a2cb46
32d0289
0bc2e29
5330cc5
682bb76
875b835
c2f6c36
fe0b699
3df9255
baef12d
c70ca5c
edf45e0
ef6503c
cc4c50b
7508ebc
cd3f4c1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is well-balancedness ever computed? As far as I can tell there is a missing function to compute this error, like the following (modulo a bunch of the comments therein. I was lazy and just copied over and slightly modified the code from the
shallow_water_1d.jl
file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can check this - I originally removed this from this PR to make it shorter, but it'd be great to demonstrate this property.