Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enstrophy for 2D Navier-Stokes #1591

Merged
merged 4 commits into from
Jul 28, 2023
Merged

Conversation

DanielDoehring
Copy link
Contributor

This PR extends functionalities existing in 3D to 2D.

Copy link
Contributor

@jlchan jlchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #1591 (9b64552) into main (fe0e78c) will increase coverage by 13.08%.
The diff coverage is 53.85%.

@@             Coverage Diff             @@
##             main    #1591       +/-   ##
===========================================
+ Coverage   83.00%   96.07%   +13.08%     
===========================================
  Files         400      401        +1     
  Lines       33019    33088       +69     
===========================================
+ Hits        27405    31789     +4384     
+ Misses       5614     1299     -4315     
Flag Coverage Δ
unittests 96.07% <53.85%> (+13.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...s/tree_2d_dgsem/elixir_navierstokes_shear_layer.jl 0.00% <0.00%> (ø)
src/callbacks_step/analysis_dg2d.jl 100.00% <100.00%> (+13.33%) ⬆️
src/equations/compressible_navier_stokes_2d.jl 98.17% <100.00%> (+0.13%) ⬆️

... and 71 files with indirect coverage changes

@DanielDoehring
Copy link
Contributor Author

Hm, the CI MPI test for mac fails when run with coverage, the non-covered version seems to be fine.

@jlchan
Copy link
Contributor

jlchan commented Jul 27, 2023

Could be related to #1590

Copy link
Contributor

@jlchan jlchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this functionality!

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ranocha ranocha merged commit e1e680c into trixi-framework:main Jul 28, 2023
30 of 31 checks passed
@DanielDoehring DanielDoehring deleted the ShearLayer branch August 11, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants