reset threads also when initializing the summary callback #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added the option to reset the threads from Polyester.jl in also in the summary callback. The idea is that this supports another development workflow where we just modify the RHS implementation and call solve again without re-ccreating the ODE. The same comment as in 036eaed applies: However, I did not document it in the docstring since we have not documented that we use Polyester.jl threads in general - and the resetting is specific to Polyester.jl. I was not sure whether we still would like to keep the option to change the threading backend any time - although I do not see a good reason why we should do so.
jlchan
previously approved these changes
Jul 25, 2023
jlchan
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the option to reset the threads from Polyester.jl in also in the summary callback. The idea is that this supports another development workflow where we just modify the RHS implementation and call solve again without re-ccreating the ODE.
See also #1584, #1583
The same comment as in 036eaed applies: However, I did not document it in the docstring since we have not documented that we use Polyester.jl threads in general - and the resetting is specific to Polyester.jl. I was not sure whether we still would like to keep the option to change the threading backend any time - although I do not see a good reason why we should do so.