Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some tests with threaded time intergation so that we can catch issues such as #1577 and SciML/OrdinaryDiffEq.jl#1989 in our CI pipeline.
I also reduced the precompilation workload of OrdinaryDiffEq.jl for CI tests to make it less expensive. We don't use all of the methods that are precompiled with the old settings, so it doesn't really help to compile them all.
There is currently an issue with threaded time integration and arrays of
SVector
s used by the flux differencingDGMulti
solver that I will report upstream.Edit: See JuliaSIMD/StrideArrays.jl#77
@trixi-framework/developers Anybody up for a review?