Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GC time percentage output #1576

Merged
merged 1 commit into from
Jul 19, 2023
Merged

fix GC time percentage output #1576

merged 1 commit into from
Jul 19, 2023

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Jul 19, 2023

We print something like GC time: 3.28885310e-02 s (0.001%) later - which assumes that gc_time_percentage is given as percent and not a fraction between zero and one.

@ranocha ranocha requested a review from sloede July 19, 2023 08:29
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 🙏

@sloede sloede enabled auto-merge (squash) July 19, 2023 09:32
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #1576 (fafd82f) into main (a12f82d) will decrease coverage by 17.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #1576       +/-   ##
===========================================
- Coverage   96.15%   79.14%   -17.01%     
===========================================
  Files         384      384               
  Lines       31998    31952       -46     
===========================================
- Hits        30767    25287     -5480     
- Misses       1231     6665     +5434     
Flag Coverage Δ
unittests 79.14% <100.00%> (-17.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/callbacks_step/analysis.jl 92.69% <100.00%> (-0.33%) ⬇️

... and 128 files with indirect coverage changes

@sloede sloede merged commit b0ec66e into main Jul 19, 2023
29 of 30 checks passed
@sloede sloede deleted the ranocha-patch-1 branch July 19, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants