Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow periodic FDSBP operators #1570

Merged
merged 4 commits into from
Jul 15, 2023
Merged

allow periodic FDSBP operators #1570

merged 4 commits into from
Jul 15, 2023

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Jul 15, 2023

I enabled the use of fully periodic FDSBP operators. It would be nice if you could take a look, @gregorgassner, since both @andrewwinters5000 and @sloede are on vacation.

@ranocha ranocha added the enhancement New feature or request label Jul 15, 2023
@ranocha ranocha mentioned this pull request Jul 15, 2023
8 tasks
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall with only minor suggestions/questions

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #1570 (2bfcb1a) into main (07981c3) will increase coverage by 7.00%.
The diff coverage is 79.55%.

@@            Coverage Diff             @@
##             main    #1570      +/-   ##
==========================================
+ Coverage   89.15%   96.15%   +7.00%     
==========================================
  Files         383      384       +1     
  Lines       31949    31998      +49     
==========================================
+ Hits        28483    30767    +2284     
+ Misses       3466     1231    -2235     
Flag Coverage Δ
unittests 96.15% <79.55%> (+7.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
examples/tree_1d_fdsbp/elixir_advection_upwind.jl 100.00% <ø> (ø)
src/solvers/fdsbp_tree/fdsbp.jl 100.00% <ø> (ø)
src/solvers/fdsbp_tree/fdsbp_1d.jl 90.14% <78.57%> (-1.40%) ⬇️
src/solvers/fdsbp_tree/fdsbp_2d.jl 90.96% <78.57%> (-1.16%) ⬇️
src/solvers/fdsbp_tree/fdsbp_3d.jl 93.07% <78.57%> (-1.14%) ⬇️
.../tree_1d_fdsbp/elixir_advection_upwind_periodic.jl 100.00% <100.00%> (ø)

... and 36 files with indirect coverage changes

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ranocha ranocha merged commit 932f433 into main Jul 15, 2023
29 of 30 checks passed
@ranocha ranocha deleted the hr/periodic_upwind branch July 15, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants