Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bunch of various improvements #16

Open
wants to merge 10 commits into
base: gh-pages
Choose a base branch
from
Open

Conversation

thorn0
Copy link

@thorn0 thorn0 commented Feb 10, 2018

See online: https://thorn0.github.io/hcl-picker

@thorn0 thorn0 changed the title 1) use newer chroma.js; 2) show clipped colors; 3) update dev dependencies A bunch of various improvements Feb 11, 2018
@thorn0 thorn0 mentioned this pull request Feb 11, 2018
@tristen
Copy link
Owner

tristen commented Feb 11, 2018

Hey @thorn0 thanks for the PR! Without diving too deeply into the changes quite yet I'm seeing some stack overflow when adjusting either slider which is locking up Chrome for me. Are you reproducing this too?


I'm a little hesitant to permit colors that fall outside the visualized color space. That said, you're handling it pretty well by marking those values in red. I wonder if there's a slightly nicer way of providing an explanation to the user why they are marked in red.


This is a weird interaction

slide

@thorn0
Copy link
Author

thorn0 commented Feb 11, 2018

Ooops, yep. I get that stack overflow too. Looking into it.

@thorn0
Copy link
Author

thorn0 commented Feb 12, 2018

I've fixed that stack overflow, but there still is another issue: the circles aren't draggable after shifting the hue.

@thorn0
Copy link
Author

thorn0 commented Feb 12, 2018

I wonder if there's a slightly nicer way of providing an explanation to the user why they are marked in red.

I have a couple of thoughts on this. We can:

  1. Show a danger sign with an explanation tooltip near those colors.
  2. Convert them back to LCH and measure the distance from the originals to estimate how "bad" they are and present this somehow. E.g. the worse the redder. If this difference is insignificant, resulting color scales should be good enough.
  3. Desaturate the resulting colors (in Lab) and show them in a separate column for the user to estimate how smooth it looks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colors don't have fixed Hue, as they're supposed to Hue slider
3 participants