-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A bunch of various improvements #16
base: gh-pages
Are you sure you want to change the base?
Conversation
Hey @thorn0 thanks for the PR! Without diving too deeply into the changes quite yet I'm seeing some stack overflow when adjusting either slider which is locking up Chrome for me. Are you reproducing this too? I'm a little hesitant to permit colors that fall outside the visualized color space. That said, you're handling it pretty well by marking those values in red. I wonder if there's a slightly nicer way of providing an explanation to the user why they are marked in red. This is a weird interaction |
Ooops, yep. I get that stack overflow too. Looking into it. |
I've fixed that stack overflow, but there still is another issue: the circles aren't draggable after shifting the hue. |
I have a couple of thoughts on this. We can:
|
See online: https://thorn0.github.io/hcl-picker