Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hydra/initial support #2

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Hydra/initial support #2

wants to merge 15 commits into from

Conversation

dragos
Copy link
Member

@dragos dragos commented Jul 21, 2018

No description provided.

@dragos
Copy link
Member Author

dragos commented Jul 21, 2018

Supersedes #1.

@dragos
Copy link
Member Author

dragos commented Jul 21, 2018 •
edited
Loading

  • Compiler plugin validation is failing right now because the Scala Installation has the revision hydraNN and ScalaIDE thinks it's binary incompatible

dotta
dotta approved these changes Jul 23, 2018
View reviewed changes
Copy link
Member

@dotta dotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metacomment: I wonder if adding a bit of logging around some operation might help if things don't work as expected (e.g., version extraction, artifacts added to the classpath, etc). But you are the one better suited to know if this is worth or not.

org.scala-ide.sdt.core/src/org/scalaide/core/internal/project/DirectoryScalaInstallation.scala Outdated
scalaSwingPrefix, hydraPrefix, hydraBridgePrefix, scalaLoggingPrefix,
logbackClassicPrefix, logbackCorePrefix, slf4jPrefix,
hydraReflectPrefix, scalaXmlPrefix, license4jPrefix,
hydraDashboardPrefix, hydraLicenseCheckingPrefix), presumedLibraryVersionString).filter {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is something that will eventually get out of sync (one day or another we might add or remove something). Not sure if it's possible to do it some other way, but I wanted to raise the concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotta dotta dotta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dragos @dotta @maris123