Add networkpolicy support
#243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdaberdaku
force-pushed
the
feature/add-networkpolicy-support
branch
4 times, most recently
from
4294f51
to
7e57736
Compare
nineinchnick
reviewed
Oct 6, 2024
nineinchnick
reviewed
Oct 6, 2024
sdaberdaku
force-pushed
the
feature/add-networkpolicy-support
branch
5 times, most recently
from
dc05770
to
88a64f0
Compare
sdaberdaku
force-pushed
the
feature/add-networkpolicy-support
branch
2 times, most recently
from
fab7474
to
c52cec5
Compare
sdaberdaku
force-pushed
the
feature/add-networkpolicy-support
branch
from
c52cec5
to
acdc512
Compare
|
Hello @nineinchnick, PR should be ready now! I also added a label to make NetworkPolicy targets explicitly distinguishable since the selectorLabels were used also in test Pods (which would then be included as policy targets as well). |
nineinchnick
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Network Policy support to the chart. Network policies are useful to protect Trino pods from unauthorized access from other Pods within the Kubernetes cluster.