Feat/implement solana staking #15409
Draft
+647
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-pvl
force-pushed
the
feat/implement-solana-staking
branch
from
5f0e506
to
47ceb8d
Compare
dev-pvl
force-pushed
the
feat/implement-solana-staking
branch
from
47ceb8d
to
e7afb45
Compare
tomasklim
requested changes
Nov 15, 2024
| @@ -25,7 +25,9 @@ export const WalletStaking = () => { | |||
| case 'cardano': | |||
| return <CardanoStakingDashboard selectedAccount={selectedAccount} />; | |||
| case 'ethereum': | |||
| return <EthStakingDashboard selectedAccount={selectedAccount} />; | |||
| return <StakingDashboard selectedAccount={selectedAccount} />; | |||
There was a problem hiding this comment.
Suggested change
| return <StakingDashboard selectedAccount={selectedAccount} />; |
| @@ -5,21 +5,25 @@ import { WalletLayout } from 'src/components/wallet'; | |||
| import { useSelector } from 'src/hooks/suite'; | |||
|
|
|||
| import { EmptyStakingCard } from './components/EmptyStakingCard'; | |||
| import { StakingDashboard } from './components/StakingDashboard'; | |||
| import { StakingDashboard as EthStakingDashboard } from '../EthStakingDashboard/components/StakingDashboard'; | |||
There was a problem hiding this comment.
could you please call the file and component EthStakingDashboard?
| @@ -8625,7 +8625,7 @@ const messages = defineMessagesWithTypeCheck({ | |||
| TR_STAKE_STAKING_IS: { | |||
| id: 'TR_STAKE_STAKING_IS', | |||
| defaultMessage: | |||
| "Staking involves temporarily locking your Ethereum assets to support the blockchain's operation. In return, you'll earn additional Ethereum as a reward.", | |||
| "Staking involves temporarily locking your {network} assets to support the blockchain's operation. In return, you'll earn additional {network} as a reward.", | |||
There was a problem hiding this comment.
Do we want to say @jirih-stsh
earn additional ETH as a reward.orearn additional Ethereum as a reward.earn additional SOL as a reward.orearn additional Solana as a reward.
| @@ -18,6 +19,8 @@ export const ACCOUNT_TABS = [ | |||
| ]; | |||
|
|
|||
| export const AccountNavigation = () => { | |||
| const isDebugModeActive = useSelector(selectIsDebugModeActive); | |||
There was a problem hiding this comment.
could you please add all those is debug things into 1 separate commit or add some specific TODOs somewhere so that we easily find what we should remove before launch?
| details: 'basic', | ||
| suppressBackupWarning: true, | ||
| }); | ||
| const [basic, stakingAccounts] = await Promise.all([ |
There was a problem hiding this comment.
note: @tomasklim TODO check if ok
| @@ -28,6 +29,10 @@ export const composeTransaction = | |||
| return dispatch(stakeFormEthereumActions.composeTransaction(formValues, formState)); | |||
| } | |||
|
|
|||
| if (account.networkType === 'solana') { | |||
|
|
||
|
|
||
|
|
||
| const calculate = ( |
There was a problem hiding this comment.
au, this file is really big copy-paste. can we try to avoid that, please
vytick
reviewed
Nov 15, 2024
| if (output.type === 'send-max' || output.type === 'send-max-noaddress') { | ||
| const minEthBalanceForStakingWei = | ||
| MIN_SOL_BALANCE_FOR_STAKING.multipliedBy(LAMPORTS_PER_SOL); | ||
| const minAmountWithFeeWei = new BigNumber(minEthBalanceForStakingWei).plus(feeInLamports); |
There was a problem hiding this comment.
Please, do not use eth referencing name where it does not belong
| return new BigNumber(amount).div(LAMPORTS_PER_SOL).toFixed(9); | ||
| }; | ||
|
|
||
| type SolhNetwork = 'devnet' | 'mainnet-beta'; |
There was a problem hiding this comment.
Suggested change
| type SolhNetwork = 'devnet' | 'mainnet-beta'; | |
| type SolNetwork = 'devnet' | 'mainnet-beta'; |
| const totalAmount = accounts.reduce((acc, solAccount) => { | ||
| const { account } = solAccount; | ||
|
|
||
| return acc.plus(account?.data.parsed.info.stake.delegation.stake); |
There was a problem hiding this comment.
this probably does not include mev kickback and rent. Do we want to count those as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Screenshots: