-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(suite): refactor staking #15391
base: develop
Are you sure you want to change the base?
Conversation
5e49c1d
to
00233a9
Compare
40b0d77
to
ff95364
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Claiming is usually not available, so most of the users will see it like this
This banner looks weird in the bottom
At the top or better at the modal header as description, it would maybe look better?
Probably you removed it in the previous refactoring but the fee component had some sort of state that the previous gas limit and gas price was visible before the new one was composed. That was there to avoid this jumping
Screen.Recording.2024-11-15.at.8.48.39.mov
Ok, I didn't know that, I thought there is always either claiming available or pending:) I'll fix that. |
/rebase |
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/11860301528 |
9c40783
to
6b12c5d
Compare
@trezor/qa this PR should be just staking UI/UX changes, but please test it properly 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolves #15398
Screenshots:
Before
After