-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syscall verifiers #4229
Open
cepetr
wants to merge
6
commits into
main
Choose a base branch
from
cepetr/syscall-verify
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Syscall verifiers #4229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[no changelog]
[no changelog]
[no changelog]
cepetr
force-pushed
the
cepetr/syscall-verify
branch
2 times, most recently
from
September 30, 2024 11:28
419af94
to
d58001f
Compare
[no changelog]
cepetr
force-pushed
the
cepetr/syscall-verify
branch
from
October 1, 2024 06:42
d58001f
to
48272d1
Compare
[no changelog]
cepetr
force-pushed
the
cepetr/syscall-verify
branch
from
October 2, 2024 05:49
48272d1
to
b283313
Compare
ibz
reviewed
Oct 2, 2024
} break; | ||
#endif | ||
|
||
#ifdef USE_OPTIGA | ||
/*optiga_sign_result optiga_sign(uint8_t index, const uint8_t *digest, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we have a SYSCALL_OPTIGA_SIGN
though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks for catching that. I've added fixed it, see 2cff1e5
[no changelog]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements syscall argument verification, ensuring passed buffers are within memory accessible to unprivileged code. It also copies data when needed to prevent TOC/TOU attacks.
Additional changes:
hash_processor
API.This resolves issue #4203.