Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamline layout definitions #4219

Merged
merged 7 commits into from
Sep 27, 2024
Merged

Conversation

TychoVrahe
Copy link
Contributor

This PR is aimed to clean some mess in layout definitions, sconscripts and other minor stuff.

  1. flash layout definitions in model_xxx.h are given some structure and consistency
  2. this then allows to use single layout.c (per mcu family) file instead of model specific layout file.
  3. sconscripts are cleaned up a bit, removed some residual model 1 mentions, got rid of exceptions for DISCovery kits, so that i.e. prodtest build is allowed for these too, reusing a recently added embed_raw_binary function to embed vendorheader
  4. added bootloader binaries for discovery kits, so that we can test bootloader upgrading on these kits
  5. SBU interface is removed from micropython, it was unused, since core-split it wouldn't work anyway and took some flash space

Note: RAM layout in model definitions is unchanged for now, but probably should get similar treatment at some point.

@TychoVrahe TychoVrahe self-assigned this Sep 25, 2024
@TychoVrahe TychoVrahe force-pushed the tychovrahe/coresplit/streamline_defs branch 7 times, most recently from 75b45c3 to 6020400 Compare September 25, 2024 14:28
@TychoVrahe TychoVrahe marked this pull request as ready for review September 25, 2024 19:33
@TychoVrahe TychoVrahe requested review from cepetr and removed request for prusnak September 25, 2024 19:33
Copy link
Contributor

@cepetr cepetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly, I didn't find any issues. Looks good to me.

Copy link

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@TychoVrahe TychoVrahe force-pushed the tychovrahe/coresplit/streamline_defs branch from 2b36421 to cbe257c Compare September 27, 2024 07:06
@TychoVrahe TychoVrahe force-pushed the tychovrahe/coresplit/streamline_defs branch from cbe257c to 95a5e56 Compare September 27, 2024 07:07
@TychoVrahe TychoVrahe merged commit 775780c into main Sep 27, 2024
85 checks passed
@TychoVrahe TychoVrahe deleted the tychovrahe/coresplit/streamline_defs branch September 27, 2024 07:49
@Hannsek
Copy link
Contributor

Hannsek commented Sep 27, 2024

The T3T1 device tests are red. Is it intentional?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

3 participants