-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
streamline layout definitions #4219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TychoVrahe
force-pushed
the
tychovrahe/coresplit/streamline_defs
branch
7 times, most recently
from
September 25, 2024 14:28
75b45c3
to
6020400
Compare
cepetr
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprisingly, I didn't find any issues. Looks good to me.
|
TychoVrahe
force-pushed
the
tychovrahe/coresplit/streamline_defs
branch
from
September 27, 2024 07:06
2b36421
to
cbe257c
Compare
[no changelog]
[no changelog]
[no changelog]
…esting related featurees [no changelog]
…aders [no changelog]
[no changelog]
[no changelog]
TychoVrahe
force-pushed
the
tychovrahe/coresplit/streamline_defs
branch
from
September 27, 2024 07:07
cbe257c
to
95a5e56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aimed to clean some mess in layout definitions, sconscripts and other minor stuff.
Note: RAM layout in model definitions is unchanged for now, but probably should get similar treatment at some point.