feat: 'units' parameter for geometry patterns #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The "geometry" patterns (e.g. "circle", "stripe", etc.) now allow the new `units` parameter to set which `grid::unit()` to use for the the `spacing`, `xoffset`, and `yoffset` parameters (and for the "wave" pattern also the `amplitude` and `frequency` parameters) (#58). By default it will continue to be "snpc" units but can now be changed to "cm", "in", etc. * The `wave` pattern no longer quietly and incorrectly ignores the `frequency` parameter. The effective wavelength of the wave pattern is now `1 / frequency` instead of `spacing`. However `frequency` will continue to default to `1 / spacing`. closes #58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "geometry" patterns (e.g. "circle", "stripe", etc.) now allow the new
unitsparameter to set whichgrid::unit()to use for the thespacing,xoffset, andyoffsetparameters (and for the "wave" pattern also theamplitudeandfrequencyparameters) (Allow spacing parameters to use cm/in instead of snpc units #58). By default it will continue to be "snpc" units but can now be changed to "cm", "in", etc.The
wavepattern no longer quietly and incorrectly ignores thefrequencyparameter. The effective wavelength of the wave pattern is now1 / frequencyinstead ofspacing. Howeverfrequencywill continue to default to1 / spacing.closes #58