New fill pattern and other updates #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For completeness there is now a `grid.pattern_none()` corresponding to the "none" pattern which draws nothing.
* For completeness there is now a new "fill" pattern with corresponding `grid.pattern_fill()` which draws a simple fill pattern.
* List new "fill" pattern * New section on how to use directly with "ggplot2" v3.5+ * Update how to use directly with "ggpattern"
* Don't include calling function name in error mesage * More consistency between `img_read()` error messages * Otherwise no big changes, message already communicates there was a problem with downloading image, not sure how that should change. closes #69
BREAKING CHANGES: * The default `type` for the "placeholder" pattern is now "bear" instead of "kitten". Explicitly set `type = "kitten"` to continue to use the "kitten" placeholder but note that although the "kitten" placeholder website isn't completely down it has been buggy recently closes #73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grid.pattern_fill()which draws a simple fill pattern.grid.pattern_none()corresponding to the previouslysupported "none" pattern which draws nothing.
typefor the "placeholder" patternis now "bear" instead of "kitten".
Explicitly set
type = "kitten"to continue to usethe "kitten" placeholder but note that although
the "kitten" placeholder website isn't completely down
it has been buggy recently.
closes #73, closes #69