Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: better dark mode (fixes #2061) #2122

Merged
merged 3 commits into from
Sep 25, 2024
Merged

all: better dark mode (fixes #2061) #2122

merged 3 commits into from
Sep 25, 2024

Conversation

Okuro3499
Copy link
Contributor

@Okuro3499 Okuro3499 commented Sep 9, 2024 •
edited
Loading

fixes #2061
001
002
003

@xyb994
Copy link
Member

xyb994 commented Sep 10, 2024

@Okuro3499 I couldn't quite get to the screen to "Add port" in "SSH" tab, but were the placeholder text there updated?

I see "Add Port" in the SSH tab is having a lighter placeholder text color, perhaps that's better to use in both "Add host" and "Add port" in tge "SSH" tab?

@dogi dogi changed the title darkmode: better contrast (fixes #2061) all: better dark mode contrast (fixes #2061) Sep 25, 2024
@dogi dogi changed the title all: better dark mode contrast (fixes #2061) all: better dark mode (fixes #2061) Sep 25, 2024
@dogi dogi merged commit 9660679 into master Sep 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogi dogi dogi approved these changes

@xyb994 xyb994 Awaiting requested review from xyb994

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

better color contrast for some text
3 participants
@Okuro3499 @xyb994 @dogi