Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python requirement to 3.8 fix dependency problem. #117

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

tetov
Copy link
Contributor

@tetov tetov commented Jan 18, 2024

Closes #116

As described in #116, this could also be solved by changing the dep on importlib-metadata to <6.8.0.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed5eb12) 92.14% compared to head (d2f3671) 93.08%.

❗ Current head d2f3671 differs from pull request most recent head f6e0d87. Consider uploading reports for the commit f6e0d87 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   92.14%   93.08%   +0.93%     
==========================================
  Files           4        4              
  Lines         191      188       -3     
==========================================
- Hits          176      175       -1     
+ Misses         15       13       -2     
Files Coverage Δ
src/nbmake/pytest_plugin.py 92.59% <100.00%> (+5.92%) ⬆️

@alex-treebeard
Copy link
Member

Thanks for this @tetov, as discussed in your issue I support your reasoning in dropping 3.7 support for subsequent releases.

The tests for 3.8 are failing and it's possibly a simple fix - specify test dependency to IPython <=8.12

ImportError:
IPython 8.13+ supports Python 3.9 and above, following NEP 29.
IPython 8.0-8.12 supports Python 3.8 and above, following NEP 29.

I'm conscious that if this is not as simple to fix it may highlight some work needed on the testing solution for this package...please let me know how it goes and I can help get this put into a release.

@tetov
Copy link
Contributor Author

tetov commented Jan 19, 2024

I should have tested on 3.8 but didn't since I couldn't apt install python3.8.. Might be easiest to use act to do tests on multiple versions.

Can you please hold off on dropping 3.8 from tests (as in #118) until I have done some work here first?

Pins to working version of ipython.
@alex-treebeard alex-treebeard merged commit f5b7174 into treebeardtech:main Jan 29, 2024
8 of 9 checks passed
@alex-treebeard
Copy link
Member

Thanks @tetov, I'm going to release this now (devcontainer error is not critical)

@alex-treebeard
Copy link
Member

Released in 1.5.0, thanks a lot for the contribution!

@tetov
Copy link
Contributor Author

tetov commented Jan 29, 2024

Happy to help! Want me to upgrade poetry in devcontainers?

@alex-treebeard
Copy link
Member

yes please, that would be awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poetry SolveProblemError due to impossible version constraints on importlib_metadata
2 participants