-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump python requirement to 3.8 fix dependency problem. #117
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 92.14% 93.08% +0.93%
==========================================
Files 4 4
Lines 191 188 -3
==========================================
- Hits 176 175 -1
+ Misses 15 13 -2
|
Thanks for this @tetov, as discussed in your issue I support your reasoning in dropping 3.7 support for subsequent releases. The tests for 3.8 are failing and it's possibly a simple fix - specify test dependency to IPython <=8.12 ImportError: I'm conscious that if this is not as simple to fix it may highlight some work needed on the testing solution for this package...please let me know how it goes and I can help get this put into a release. |
Pins to working version of ipython.
Thanks @tetov, I'm going to release this now (devcontainer error is not critical) |
Released in 1.5.0, thanks a lot for the contribution! |
Happy to help! Want me to upgrade poetry in devcontainers? |
yes please, that would be awesome |
Closes #116
As described in #116, this could also be solved by changing the dep on importlib-metadata to
<6.8.0
.