add CI workflow, and update tree-sitter #4
Conversation
|
Please use the official workflows: https://github.com/tree-sitter/workflows |
erik-krogh
force-pushed
the
erik-krogh-patch-1
branch
from
6fa7a21
to
b66431c
Compare
…y `tree-sitter generate` does not work with the reference tree-sitter workflow
Cargo.toml
Outdated
| @@ -1,26 +1,23 @@ | |||
| [package] | |||
| name = "tree-sitter-ql-dbscheme" | |||
| description = "ql dbscheme grammar for the tree-sitter parsing library" | |||
| name = "tree-sitter-dbscheme" | |||
There was a problem hiding this comment.
Not sure about this rename. The repo is still called tree-sitter-ql-dbscheme, after all.
There was a problem hiding this comment.
But the parser is. Having the repo named different from the language is not really intended.
There was a problem hiding this comment.
That is because the name in gammar.js is wrong. The generate script is copy-pasting from there.
I'm fixing it.
There was a problem hiding this comment.
I'm not sure I follow. The parser is what? (Edit: Ah, @erik-krogh's interim answer cleared this up for me.)
Currently, the name of the parser is tree-sitter-ql-dbscheme. This is also how the (to my knowledge) only downstream user refers to it.
To be clear, I would be happy to see this renamed to tree-sitter-dbscheme. The original name contained -ql- out of an abundance of caution, in case some other user of dbscheme was out there.
There was a problem hiding this comment.
Currently the grammar is named dbscheme.
I cannot change it to ql-dbscheme, because then tree-sitter gives me the following error:
Error: Grammar's 'name' property must not start with a digit and cannot contain non-word characters..
What can we do?
There was a problem hiding this comment.
(To be clear, I'm not saying you're doing it wrong; I'm just pointing out that the tooling is built with different expectations, so you can't trust it blindly if you deviate. You'll just have to postprocess manually.)
There was a problem hiding this comment.
Underscore seem to work
There was a problem hiding this comment.
Yep, a number of other grammars use that trick.
No description provided.