Skip to content

Commit

Permalink
post review 4
Browse files Browse the repository at this point in the history
  • Loading branch information
treblereel committed Jan 26, 2024
1 parent a34536b commit 6afe22d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 11 deletions.
10 changes: 0 additions & 10 deletions build-caching/src/main/java/com/vertispan/j2cl/build/Project.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import java.util.Collections;
import java.util.HashSet;
import java.util.List;
import java.util.Optional;
import java.util.Set;
import java.util.zip.ZipEntry;
import java.util.zip.ZipFile;
Expand Down Expand Up @@ -98,10 +97,6 @@ public boolean isJsZip() {
return isJsZip;
}

/**
* If this dependency is a maven external dependency, return the jar file that represents it.
* @return File pointing at the jar, or null if this is a maven reactor project.
*/
@Override
public File getJar() {
return jar;
Expand All @@ -111,11 +106,6 @@ public void setJar(File jar) {
this.jar = jar;
}

/**
* If this project is a maven external dependency and has an annotation processors in it,
* return the set of declared processors. If this is a maven reactor project (with annotataion processor or not),
* return an empty set.
*/
@Override
public Set<String> getProcessors() {
if (processors == null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,16 @@ public interface Project {
*/
boolean isJsZip();

/**
* If this dependency is a maven external dependency, return the jar file that represents it.
* @return File pointing at the jar, or null if this is a maven reactor project.
*/
File getJar();

/**
* @return the set of annotation processors that should be run on this project
* If this project is a maven external dependency and has an annotation processors in it,
* return the set of declared processors. If this is a maven reactor project (with annotataion processor or not),
* return an empty set.
*/
Set<String> getProcessors();

Expand Down

0 comments on commit 6afe22d

Please sign in to comment.