Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enableAutoTrackingIP & disableAutoTrackingIP #131

Merged
merged 6 commits into from
Jun 25, 2024
Merged

Add enableAutoTrackingIP & disableAutoTrackingIP #131

merged 6 commits into from
Jun 25, 2024

Conversation

tung-vu-td
Copy link
Contributor

New feature:

  • enableAutoTrackingIP will tell TD backend to add td_ip column with the device ip
  • disableAutoTrackingIP will disable this behavior.

Note: IP is tracked at the request level. Which means the IP address is the one when uploadEvents is called.

@tung-vu-td tung-vu-td requested a review from a team as a code owner June 18, 2024 10:53
@kietdo360 kietdo360 requested a review from imnutz June 18, 2024 22:45
kietdo360
kietdo360 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@kietdo360 kietdo360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kietdo360
Copy link
Collaborator

Still LGTM

@kietdo360 kietdo360 requested a review from a team June 25, 2024 03:20
imnutz
imnutz approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@imnutz imnutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmpennypacker
nmpennypacker approved these changes Jun 25, 2024
View reviewed changes
Copy link

@nmpennypacker nmpennypacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for data exfiltrations

@tung-vu-td tung-vu-td merged commit 8db2141 into master Jun 25, 2024
7 checks passed
@tung-vu-td tung-vu-td deleted the auto-tracking-ip branch June 25, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imnutz imnutz imnutz approved these changes

@nmpennypacker nmpennypacker nmpennypacker approved these changes

@kietdo360 kietdo360 Awaiting requested review from kietdo360

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tung-vu-td @kietdo360 @imnutz @nmpennypacker