Use sdkmanager for Android builds #837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jawnnypoo thanks for bringing this. This issue has also been reported upstream (gildegoma/chef-android-sdk#34). |
|
Looks good. But what with the backward compatibility. Look at rjaros87/chef-android-sdk#2 |
|
Ahh @rjaros87 I did not realize this was a WIP in the other repo. I will go ahead and close this one, as it seems that one is more complete. I am guessing that will eventually make it into the official cookbook? |
|
@Jawnnypoo 👍 Yup, I'll take care to encourage Travis builders to update |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, let me say I have no experience setting up a cookbook.
I am trying to get the ball rolling on updating Android builds to use sdkmanager instead of the now somewhat obsolete
updatecommand.Main reasoning for this is that certain newer features in the SDK are only available to download via the
sdkmanagercommand line tool, such as CMake for Android builds (see this issue)The tests are passing on my repo, but I have doubts that I have set this up correctly. For reference, here is how I use
sdkmanageron builds done on GitLab CIhttps://gitlab.com/Commit451/LabCoat/blob/master/.gitlab-ci.yml
Is there someone who can help me out on this? Possibly @gildegoma ?