Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#86 show throws on non-interactive backend #135

Merged
merged 2 commits into from
Mar 14, 2019

Conversation

martinjrobins
Copy link
Collaborator

Fixes #86

Figure::show() now throws when given a non-interactive backend

was thinking that interactive backends should get their own base class, see #134

@codecov
Copy link

codecov bot commented Feb 23, 2019

Codecov Report

Merging #135 into master will decrease coverage by 1.01%.
The diff coverage is 59.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
- Coverage   92.65%   91.63%   -1.02%     
==========================================
  Files          65       65              
  Lines        3389     3442      +53     
==========================================
+ Hits         3140     3154      +14     
- Misses        249      288      +39
Impacted Files Coverage Δ
src/backend/BackendSVG.hpp 77.77% <ø> (ø) ⬆️
tests/TestFigure.cpp 100% <100%> (ø) ⬆️
src/frontend/Figure.tcc 40% <100%> (-60%) ⬇️
src/backend/BackendSVG.cpp 72.4% <30.76%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd9df3b...39157da. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 23, 2019

Codecov Report

Merging #135 into master will decrease coverage by 0.94%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #135      +/-   ##
=========================================
- Coverage   92.65%   91.7%   -0.95%     
=========================================
  Files          65      65              
  Lines        3389    3423      +34     
=========================================
- Hits         3140    3139       -1     
- Misses        249     284      +35
Impacted Files Coverage Δ
src/backend/BackendSVG.hpp 77.77% <ø> (ø) ⬆️
src/frontend/Data.cpp 98.54% <100%> (-0.16%) ⬇️
tests/TestFigure.cpp 100% <100%> (ø) ⬆️
src/frontend/Figure.tcc 40% <100%> (-60%) ⬇️
src/backend/BackendSVG.cpp 73.55% <52.63%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd9df3b...b498f5e. Read the comment docs.

@martinjrobins
Copy link
Collaborator Author

the coverage on this one is so poor cause I created a bunch of new functions in BackendSVG that are never meant to be called. Hence #134....

@martinjrobins martinjrobins merged commit 7f6c5cd into trase-cpp:master Mar 14, 2019
@martinjrobins martinjrobins deleted the issue-86-show branch March 14, 2019 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant