Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

add additional field merge_commit_sha to pull requests which is a rea… #16

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

ttqin
Copy link
Contributor

@ttqin ttqin commented Sep 13, 2023

…lly helpful relational link

Problem

pull_request schema has a really important linking id of the merge commit hash, when the pull request is merged (and later closed). this isn't currently populated, and presumably the field is thrown away from the response.

Proposed changes

Add the merge_commit_sha field to the necessary schema

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@teaf-wise teaf-wise merged commit f1b2351 into main Sep 13, 2023
6 checks passed
@teaf-wise teaf-wise deleted the pull-request-missing-field branch September 13, 2023 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants