-
Notifications
You must be signed in to change notification settings - Fork 14
Eupay 452 vrp consent event subscription #170
Conversation
src/main/java/com/transferwise/openbanking/client/api/event/EventClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/transferwise/openbanking/client/api/event/EventClient.java
Show resolved
Hide resolved
src/main/java/com/transferwise/openbanking/client/api/event/EventClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/transferwise/openbanking/client/api/event/RestEventClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/transferwise/openbanking/client/api/event/RestEventClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/transferwise/openbanking/client/api/event/RestEventClient.java
Outdated
Show resolved
Hide resolved
Don't forget to bump version in gradle properties here |
src/main/java/com/transferwise/openbanking/client/api/event/EventClient.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update CHANGELOG file
src/main/java/com/transferwise/openbanking/client/api/event/EventClient.java
Show resolved
Hide resolved
src/main/java/com/transferwise/openbanking/client/api/event/EventClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/transferwise/openbanking/client/api/event/RestEventClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/transferwise/openbanking/client/api/event/RestEventClient.java
Outdated
Show resolved
Hide resolved
src/test/java/com/transferwise/openbanking/client/api/event/RestEventClientTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/transferwise/openbanking/client/api/event/RestEventClientTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/transferwise/openbanking/client/api/event/RestEventClientTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash all your commits before I can approve it as we cannot force push to master and you have 17 commits in the PR.
Also please rebase/merge master to get latest changes
d1f4638
to
00a5220
Compare
|
src/test/java/com/transferwise/openbanking/client/api/event/RestEventClientTest.java
Outdated
Show resolved
Hide resolved
Please make sure you answered and resolved all my questions in this PR.
I mean squash them in the brach as you can make a mistake and choose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…n API spec. Added specs from: https://github.com/OpenBankingUK/read-write-api-specs/blob/8a1f99fbe443c7c7eba2eff933e7f952811941c6/dist/openapi/events-openapi.yaml https://github.com/OpenBankingUK/read-write-api-specs/blob/8a1f99fbe443c7c7eba2eff933e7f952811941c6/dist/openapi/payment-initiation-openapi.json build using: ./gradlew build Generated following java class: ├── Links.java ├── Meta.java ├── OBError1.java ├── OBErrorResponse1.java ├── OBEventPolling1.java ├── OBEventPolling1SetErrs.java ├── OBEventPollingResponse1.java ├── OBEventSubscription1.java ├── OBEventSubscription1Data.java ├── OBEventSubscriptionResponse1.java ├── OBEventSubscriptionResponse1Data.java ├── OBEventSubscriptionsResponse1.java ├── OBEventSubscriptionsResponse1Data.java └── OBEventSubscriptionsResponse1DataEventSubscription.java Signed-off-by: Vivek Kumar <[email protected]>
…t attributes. I had used open API JSON spec in event-openapi-config but it should contain attrbibutes which will help swagger in generating correct package and format. format is similar what was there in VRP (vrp-openapi-config.json) There were some missing entries in gradle.build for currect formating of auto generating files I have added those entries too (similar to VRP) Signed-off-by: Vivek Kumar <[email protected]>
…_MAJOR_VERSION constant in file to use in multiple API Usages: generateApiUrl, generateVrpApiUrl Why? checkstyleMain produce error if some constant are repeated for 3 types. String "3" was passed in above 2 API and I am creating a new function for EventAPI. Signed-off-by: Vivek Kumar <[email protected]>
…PI in RestEventClent EventClient is interface. RestEventClient is implementation of EventClient and logic to call ASPSP reside here. EventApiCallException is exception thrown in case EventSubscription call error. BasePaymentClient contains the URL generation util function for ASPSP event API. Signed-off-by: Vivek Kumar <[email protected]>
…subscribeToAnEvent. Used: 1. MockRestServiceServer 2. Mockito to mock OAuthClient and jwtClaimsSigner. Verified the following. URL : https://aspsp.co.uk/open-banking/v3.1/event-subscriptions Signed-off-by: Vivek Kumar <[email protected]>
Signed-off-by: Vivek Kumar <[email protected]>
it calls to: GET /event-supscriptions Data Model: Response: OBEventSubscriptionsResponse1 Test: verified GET URL: https://aspsp.co.uk/open-banking/v3.1/event-subscriptions Signed-off-by: Vivek Kumar <[email protected]>
URL: DELETE /event-subscriptions/{event-subscription-id} DataModel No Model is requested or returned. Result: Verify 200 code. Test URL /event-subscriptions/{event-subscription-id} is called. Test somehow is not working, Will fix in later commit. Signed-off-by: Vivek Kumar <[email protected]>
Signed-off-by: Vivek Kumar <[email protected]>
Signed-off-by: Vivek Kumar <[email protected]>
…estEventClient Signed-off-by: Vivek Kumar <[email protected]>
Signed-off-by: Vivek Kumar <[email protected]>
URL: PUT /event-subscriptions/{EventSubscriptionId} Data Model: Request: OBEventSubscriptionResponse1 Response: OBEventSubscriptionResponse1 Test: RestEventClientTest::changeEventSubscriptions Verified URL is correct. Signed-off-by: Vivek Kumar <[email protected]>
Signed-off-by: Vivek Kumar <[email protected]>
Signed-off-by: Vivek Kumar <[email protected]>
Description: Considering it as a major version as we are provide support for a new Event API Signed-off-by: Vivek Kumar <[email protected]>
Signed-off-by: Vivek Kumar <[email protected]>
Signed-off-by: Vivek Kumar <[email protected]>
Signed-off-by: Vivek Kumar <[email protected]>
Signed-off-by: Vivek Kumar <[email protected]>
Signed-off-by: Vivek Kumar <[email protected]>
…ientTest Signed-off-by: Vivek Kumar <[email protected]>
Why? We need to unified error handling for VRP, PISP and Event. Enum will be handy to merge them. Guarantees: Bank have option to send a new Custom error string which is not listed in enum. But they will introduce a new version for any update. We can raise ticket to bank for any custom changes. Signed-off-by: Vivek Kumar <[email protected]>
Signed-off-by: Vivek Kumar <[email protected]>
ca2a82e
to
002e5cb
Compare
Merged with Master! |
Context
To Improve the VRP experience, we want to get notified when User cancelled the VRP consent through ASPSP.
Open Banking provide Event API through which ASPSP can notify us whenever User revoked the consent.
Changes
subscribeToAnEvent
,getAllEventResources
,changeAnEventResource
,deleteAnEventResource