Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix curl-unencrypted #54

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Fix curl-unencrypted #54

merged 2 commits into from
Mar 11, 2024

Conversation

LewisArdern
Copy link
Contributor

@LewisArdern LewisArdern commented Mar 6, 2024 •
edited
Loading

We had reports of false positives for this rule, this PR addresses it.

We shouldn't flag findings for localhost or 127.0.0.1

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@GrosQuildu GrosQuildu self-assigned this Mar 11, 2024
GrosQuildu
GrosQuildu requested changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@GrosQuildu GrosQuildu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the nitpick, but breaks our Actions.

Thanks for the PR!

generic/curl-unencrypted-url.yaml Outdated Show resolved Hide resolved
generic/curl-unencrypted-url.yaml Outdated Show resolved Hide resolved
@GrosQuildu GrosQuildu merged commit b5f7c2e into trailofbits:main Mar 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrosQuildu GrosQuildu GrosQuildu requested changes

Assignees

@GrosQuildu GrosQuildu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LewisArdern @CLAassistant @GrosQuildu