added a fix for FPs found by anonymous-race-condition

[hex0punk]

The anonymous-race-condition rule was returning FPs for cases such as these where the two loop variables are shadowed and later used in an anon func:

func AnonRaceCond_5() {
	var wg sync.WaitGroup
	for idx, val := range values {
		wg.Add(1)
		idx, val := idx, val
		go func() {
			val.s.Method("test")
			fmt.Println("Completed index", idx)
			wg.Done()
		}()
	}

	wg.Wait()
}

func AnonRaceCond_6() {
	var wg sync.WaitGroup
	for idx, val := range values {
		wg.Add(1)
		idx, val := idx, val
		go func() {
			fmt.Println(val.s)
			fmt.Println("Completed index", idx)
			wg.Done()
		}()
	}

	wg.Wait()
}

This add two pattern-not that fix that.

[Vasco-jofra]

LGTM. Thank you Alex!

Regarding test failures:

• With semgrep 1.19.0 the tests pass
• With semgrep 1.29.0 the two tests fail

This is likely a bug in semgrep or some behavior that changed and that we need to account for.

[hex0punk]

Hey @Vasco-jofra!

Yeah, it has t do with a bug in how Semgrep 1.29.0 treats make in Go, but it should be fixed in the next release (maybe today). See https://semgrep.slack.com/archives/C018NJRRCJ0/p1687897157857999

[GrosQuildu]

Cannot test because semgrep/semgrep#8120 (comment)

[hex0punk]

Cannot test because returntocorp/semgrep#8120 (comment)

In this case the test is failing because of semgrep/semgrep#8171 which should be fixed once semgrep/semgrep#8179 makes int the next release

[hex0punk]

@GrosQuildu, all tests now pass with the latest release