-
Notifications
You must be signed in to change notification settings - Fork 32
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
fac829d
commit 8cabf7a
Showing
4 changed files
with
105 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
package main | ||
|
||
func Test() { | ||
// ruleid: eth-rpc-tracetransaction | ||
data, err := client.TraceTransaction(ctx, "hash", nil) | ||
// ruleid: eth-rpc-tracetransaction | ||
data, err := client.TraceBlockByNumber(ctx, 5, nil) | ||
// ruleid: eth-rpc-tracetransaction | ||
data, err := client.TraceBlockByHash(ctx, []byte{0x05}, nil) | ||
// ruleid: eth-rpc-tracetransaction | ||
data, err := client.TraceBlock(ctx, []byte{0x05}, nil) | ||
// ruleid: eth-rpc-tracetransaction | ||
data, err := client.TraceChain(ctx, 5, nil) | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
rules: | ||
- id: eth-rpc-tracetransaction | ||
message: >- | ||
Using built-in transaction tracers can be dangerous if measures are not taken to filter out reverted call frames. | ||
Review the related code to ensure the following properties: | ||
1. Reverted call frames and their associated subtraces are filtered out from any analysis. | ||
2. The transaction being traced is from a finalized block. | ||
severity: WARNING | ||
languages: [go] | ||
pattern-either: | ||
# Calls directly into Geth's API | ||
- pattern: $RECEIVER.TraceTransaction($CTX, $FILTER, $TRACECONF) | ||
- pattern: $RECEIVER.TraceBlockByNumber($CTX, $FILTER, $TRACECONF) | ||
- pattern: $RECEIVER.TraceBlockByHash($CTX, $FILTER, $TRACECONF) | ||
- pattern: $RECEIVER.TraceBlock($CTX, $FILTER, $TRACECONF) | ||
- pattern: $RECEIVER.TraceChain($CTX, ...) | ||
# RPC calls over HTTP API to geth/node provider | ||
- pattern-regex: .*debug_traceBlock.* | ||
- pattern-regex: .*debug_traceTransaction.* | ||
- pattern-regex: .*debug_traceCall.* | ||
- pattern-regex: .*debug_traceBlockByNumber.* | ||
- pattern-regex: .*debug_traceBlockByHash.* | ||
# RPC calls over HTTP API to non-geth client/node provider | ||
- pattern-regex: .*trace_block.* | ||
- pattern-regex: .*trace_transaction.* | ||
- pattern-regex: .*trace_replayBlockTransactions.* | ||
- pattern-regex: .*trace_replayTransaction.* | ||
- pattern-regex: .*trace_filter.* | ||
- pattern-regex: .*trace_call.* | ||
- pattern-regex: .*trace_callMany.* | ||
- pattern-regex: .*trace_get.* | ||
metadata: | ||
category: security | ||
technology: [ethereum, blockchain, geth] | ||
subcategory: [audit] | ||
cwe: "CWE-1284: Improper Validation of Specified Quantity in Input" | ||
confidence: LOW | ||
impact: HIGH | ||
likelihood: MEDIUM | ||
description: Detects attempts to extract trace information from an EVM transaction or block | ||
references: | ||
- https://blog.trailofbits.com/2023/08/23/the-engineers-guide-to-blockchain-finality/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
package main | ||
|
||
import ( | ||
"github.com/ethereum/go-ethereum/common" | ||
"github.com/ethereum/go-ethereum/common/hexutil" | ||
"github.com/ethereum/go-ethereum/crypto" | ||
"github.com/ethereum/go-ethereum/core/types" | ||
"github.com/ethereum/go-ethereum/rlp" | ||
) | ||
|
||
|
||
func Test() { | ||
var debug Receipt | ||
// ruleid: eth-txreceipt-status | ||
a := debug.Status | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
rules: | ||
- id: eth-txreceipt-status | ||
message: >- | ||
A transaction receipt's status is inspected using `$RECEIVER.Status()`. For bridges and exchanges, this is a high-risk pattern because even though the transaction was successful, calls within the transaction may have failed. Review the related code to ensure the following properties: | ||
1. The receipt's success is not being used as a verification measure. | ||
2. The transaction being inspected is from a finalized block. | ||
severity: WARNING | ||
languages: [go] | ||
patterns: | ||
- pattern: | | ||
import "github.com/ethereum/go-ethereum/core/types" | ||
... | ||
$RECEIVER.$FUNCTION | ||
- metavariable-pattern: | ||
metavariable: $FUNCTION | ||
pattern: Status | ||
- focus-metavariable: $FUNCTION | ||
metadata: | ||
category: security | ||
confidence: LOW | ||
impact: HIGH | ||
likelihood: MEDIUM | ||
technology: | ||
- ethereum | ||
- blockchain | ||
- geth | ||
subcategory: | ||
- audit | ||
cwe: "CWE-437: Incomplete Model of Endpoint Features" | ||
description: Detects when a transaction receipt's status is read | ||
references: | ||
- https://blog.trailofbits.com/2023/08/23/the-engineers-guide-to-blockchain-finality/ |