Skip to content

Commit

Permalink
fix: cran checks/revdeps/urlcheck
Browse files Browse the repository at this point in the history
  • Loading branch information
trafficonese committed Jun 10, 2024
1 parent 4efcc13 commit 6a5189e
Show file tree
Hide file tree
Showing 9 changed files with 47 additions and 226 deletions.
1 change: 0 additions & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ Description: The 'leaflet' JavaScript library provides many plugins some of whic
plugins.
License: GPL-3 | file LICENSE
Encoding: UTF-8
LazyData: true
Depends:
R (>= 3.1.0),
leaflet (>= 2.0.0)
Expand Down
6 changes: 3 additions & 3 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
- [email protected] - https://github.com/mapshakers/leaflet-icon-pulse
- [email protected] - https://github.com/stefanocudini/leaflet-search
- [email protected] - https://github.com/CliffCloud/Leaflet.Sleep
- [email protected] - https://github.com/ursudio/webgl-heatmap-leaflet
- [email protected] - https://github.com/ursudio/leaflet-webgl-heatmap
- [email protected] - https://github.com/maximeh/leaflet.bouncemarker
- [email protected] - https://github.com/Leaflet/Leaflet.heat
- [email protected] - https://github.com/MazeMap/Leaflet.TileLayer.PouchDBCached
Expand Down Expand Up @@ -125,7 +125,7 @@

## New Features

* Added support for [Leaflet-search](https://github.com/stefanocudini/leaflet-search) plugin. Contributed by [Bangyou Zheng](https://github.com/bhaskarvk/leaflet.extras/pull/15).
* Added support for [Leaflet-search](https://github.com/stefanocudini/leaflet-search) plugin. Contributed by [Bangyou Zheng](https://github.com/trafficonese/leaflet.extras/pull/15).

# leaflet.extras 0.1.9002

Expand Down Expand Up @@ -212,7 +212,7 @@

## New Features

* Added [webgl-heatmap](https://github.com/ursudio/webgl-heatmap-leaflet) plugin
* Added [webgl-heatmap](https://github.com/ursudio/leaflet-webgl-heatmap) plugin
* Added [geojson-choropleth](https://github.com/bhaskarvk/leaflet-choropleth) plugin
* Added [Weather Markers](https://github.com/tallsam/Leaflet.weather-markers) plugin
* Added [Pulse Icon](https://github.com/mapshakers/leaflet-icon-pulse) plugin
5 changes: 3 additions & 2 deletions R/sharamov.R
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ bingLayerDependencies <- function() {
#' @param imagerySet String. Type of Tiles to display
#' @param layerId String. An optional unique ID for the layer
#' @param group String. An optional group name for the layer
#' @param ... Optional Parameters required by the Bing API described at \url{https://msdn.microsoft.com/en-us/library/ff701716.aspx}
#' @seealso Get a Bing Maps API Key: \url{https://msdn.microsoft.com/en-us/library/ff428642.aspx}
#' @param ... Optional Parameters required by the Bing API described at
#' \url{https://learn.microsoft.com/en-us/bingmaps/getting-started/bing-maps-dev-center-help/getting-a-bing-maps-key?redirectedfrom=MSDN}
#' @seealso Get a Bing Maps API Key: \url{https://learn.microsoft.com/en-us/bingmaps/rest-services/imagery/get-imagery-metadata?redirectedfrom=MSDN}
#' @export
addBingTiles <- function(
map,
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
[![R-CMD-check](https://github.com/trafficonese/leaflet.extras/actions/workflows/R-CMD-check.yaml/badge.svg)](https://github.com/trafficonese/leaflet.extras/actions/workflows/R-CMD-check.yaml)
[![Project Status: Active – The project is being actively
developed.](http://www.repostatus.org/badges/latest/active.svg)](http://www.repostatus.org/#active)
[![Last-changedate](https://img.shields.io/badge/last%20change-2024--04--04-green.svg)](/commits/master)
[![Last-changedate](https://img.shields.io/badge/last%20change-2024--06--10-green.svg)](/commits/master)
[![License:
GPL-3](https://img.shields.io/badge/License-GPLv3-yellow.svg)](https://opensource.org/licenses/GPL-3.0)
[![packageversion](https://img.shields.io/badge/Package%20version-1.0.0.9000-orange.svg?style=flat-square)](commits/master)
Expand Down
22 changes: 22 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,25 @@
## 2024-6-10

- I will be the new maintainer
- I updated most JavaScript dependencies, added new features and fixed some bugs

## Test environments
Local (Windows 11 x64 (build 22631) - R version 4.4.0 Patched)
0 errors ✔ | 0 warnings ✔ | 0 notes ✔

All checks on GHA are fine with this setup:
- {os: macos-latest, r: 'release'}
- {os: windows-latest, r: 'release'}
- {os: ubuntu-latest, r: 'devel', http-user-agent: 'release'}
- {os: ubuntu-latest, r: 'release'}
- {os: ubuntu-latest, r: 'oldrel-1'}

## revdepcheck results
We checked 17 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
* We saw 0 new problems
* We failed to check 0 packages


# Comments

## 2018-4-21
Expand Down
5 changes: 3 additions & 2 deletions man/addBingTiles.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

49 changes: 13 additions & 36 deletions revdep/README.md
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
These are *partial* results!

# Platform

|field |value |
|:--------|:------------------------------------------------------------------------------------|
|version |R version 4.3.1 (2023-06-16 ucrt) |
|os |Windows 11 x64 (build 22631) |
|system |x86_64, mingw32 |
|ui |RStudio |
|language |(EN) |
|collate |German_Austria.utf8 |
|ctype |German_Austria.utf8 |
|tz |Europe/Vienna |
|date |2024-04-04 |
|rstudio |2023.06.0+421 Mountain Hydrangea (desktop) |
|pandoc |3.1.1 @ C:/Program Files/RStudio/resources/app/bin/quarto/bin/tools/ (via rmarkdown) |
|field |value |
|:--------|:-------------------------------------------------------------------------------------|
|version |R version 4.4.0 Patched (2024-05-26 r86642 ucrt) |
|os |Windows 11 x64 (build 22631) |
|system |x86_64, mingw32 |
|ui |RStudio |
|language |(EN) |
|collate |German_Austria.utf8 |
|ctype |German_Austria.utf8 |
|tz |Europe/Vienna |
|date |2024-06-10 |
|rstudio |2024.04.1+748 Chocolate Cosmos (desktop) |
|pandoc |3.1.11 @ C:/Program Files/RStudio/resources/app/bin/quarto/bin/tools/ (via rmarkdown) |

# Dependencies

Expand Down Expand Up @@ -71,24 +69,3 @@ These are *partial* results!

# Revdeps

## All (16)

|package |version |error |warning |note |
|:---------------|:-------|:-----|:-------|:----|
|bcdata |0.4.1 | | | |
|berryFunctions |1.22.5 | | | |
|GPSeqClus |1.4.0 | | | |
|gwavr |0.2.0 | | | |
|hydflood |0.5.7 | | | |
|[HYPEtools](problems.md#hypetools)|1.6.1 |1 | | |
|[IceSat2R](problems.md#icesat2r)|1.0.4 | | |1 |
|lcars |0.3.8 | | | |
|[leaflet.esri](problems.md#leafletesri)|1.0.0 | | |1 |
|[mapedit](problems.md#mapedit)|0.6.0 | | |2 |
|MDMAPR |0.2.3 | | | |
|[naturaList](problems.md#naturalist)|0.5.2 | |1 |1 |
|[oceanis](problems.md#oceanis)|1.8.5 | | |1 |
|[pdxTrees](problems.md#pdxtrees)|0.4.0 | | |1 |
|rfars |1.1.0 | | | |
|starsTileServer |0.1.1 | | | |

2 changes: 1 addition & 1 deletion revdep/cran.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## revdepcheck results

We checked 16 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
We checked 17 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 0 new problems
* We failed to check 0 packages
Expand Down
181 changes: 1 addition & 180 deletions revdep/problems.md
Original file line number Diff line number Diff line change
@@ -1,180 +1 @@
# HYPEtools

<details>

* Version: 1.6.1
* GitHub: https://github.com/rcapell/HYPEtools
* Source code: https://github.com/cran/HYPEtools
* Date/Publication: 2024-01-12 17:20:02 UTC
* Number of recursive dependencies: 164

Run `revdepcheck::revdep_details(, "HYPEtools")` for more info

</details>

## In both

* checking examples ... ERROR
```
Running examples in 'HYPEtools-Ex.R' failed
The error most likely occurred in:
> ### Name: SumUpstreamArea
> ### Title: Calculate upstream area sums
> ### Aliases: SumUpstreamArea
>
> ### ** Examples
>
> te <- ReadGeoData(filename = system.file("demo_model", "GeoData.txt", package = "HYPEtools"))
> SumUpstreamArea(subid = c(3361, 63794), gd = te, progbar = FALSE)
Error in checkForRemoteErrors(val) :
2 nodes produced errors; first error: there is no package called 'HYPEtools'
Calls: SumUpstreamArea ... clusterApply -> staticClusterApply -> checkForRemoteErrors
Execution halted
```

# IceSat2R

<details>

* Version: 1.0.4
* GitHub: https://github.com/mlampros/IceSat2R
* Source code: https://github.com/cran/IceSat2R
* Date/Publication: 2022-11-17 07:50:02 UTC
* Number of recursive dependencies: 140

Run `revdepcheck::revdep_details(, "IceSat2R")` for more info

</details>

## In both

* checking data for non-ASCII characters ... NOTE
```
Hinweis: 10 markierte UTF-8 Zeichenketten gefunden<
```

# leaflet.esri

<details>

* Version: 1.0.0
* GitHub: https://github.com/bhaskarvk/leaflet.esri
* Source code: https://github.com/cran/leaflet.esri
* Date/Publication: 2018-04-23 22:31:56 UTC
* Number of recursive dependencies: 49

Run `revdepcheck::revdep_details(, "leaflet.esri")` for more info

</details>

## In both

* checking LazyData ... NOTE
```
'LazyData' is specified without a 'data' directory
```

# mapedit

<details>

* Version: 0.6.0
* GitHub: https://github.com/r-spatial/mapedit
* Source code: https://github.com/cran/mapedit
* Date/Publication: 2020-02-02 17:20:02 UTC
* Number of recursive dependencies: 95

Run `revdepcheck::revdep_details(, "mapedit")` for more info

</details>

## In both

* checking package dependencies ... NOTE
```
Package which this enhances but not available for checking: 'geojsonio'
```

* checking LazyData ... NOTE
```
'LazyData' is specified without a 'data' directory
```

# naturaList

<details>

* Version: 0.5.2
* GitHub: https://github.com/avrodrigues/naturaList
* Source code: https://github.com/cran/naturaList
* Date/Publication: 2024-02-06 08:10:02 UTC
* Number of recursive dependencies: 119

Run `revdepcheck::revdep_details(, "naturaList")` for more info

</details>

## In both

* checking for missing documentation entries ... WARNING
```
Warnung: Paket 'sp' wurde unter R Version 4.3.3 erstellt
Warnung: Paket 'raster' wurde unter R Version 4.3.3 erstellt
All user-level objects in a package should have documentation entries.
See chapter 'Writing R documentation files' in the 'Writing R
Extensions' manual.
```

* checking data for non-ASCII characters ... NOTE
```
Hinweis: 5 markierte Latin-1 Zeichenketten gefunden<
Hinweis: 7187 markierte UTF-8 Zeichenketten gefunden<
```

# oceanis

<details>

* Version: 1.8.5
* GitHub: https://github.com/insee-psar-at/oceanis-package
* Source code: https://github.com/cran/oceanis
* Date/Publication: 2022-07-13 13:10:02 UTC
* Number of recursive dependencies: 117

Run `revdepcheck::revdep_details(, "oceanis")` for more info

</details>

## In both

* checking installed package size ... NOTE
```
installed size is 9.4Mb
sub-directories of 1Mb or more:
R 1.5Mb
doc 5.7Mb
extdata 1.5Mb
```

# pdxTrees

<details>

* Version: 0.4.0
* GitHub: https://github.com/mcconvil/pdxTrees
* Source code: https://github.com/cran/pdxTrees
* Date/Publication: 2020-08-17 14:00:02 UTC
* Number of recursive dependencies: 106

Run `revdepcheck::revdep_details(, "pdxTrees")` for more info

</details>

## In both

* checking LazyData ... NOTE
```
'LazyData' is specified without a 'data' directory
```

*Wow, no problems at all. :)*

0 comments on commit 6a5189e

Please sign in to comment.