Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import generic functions from extracted Go code as interpreted code #1647

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

import generic functions from extracted Go code as interpreted code #1647

wants to merge 17 commits into from

Commits on Jul 6, 2024

  1. initial implementation of x/packages based extraction; not working yet

    @kkoreilly
    kkoreilly committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    e9faf21 View commit details
    Browse the repository at this point in the history

  2. handle pkg.Errors

    @kkoreilly
    kkoreilly committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    1c53a7f View commit details
    Browse the repository at this point in the history

  3. use Chdir and ipp for Extract and importPath

    @kkoreilly
    kkoreilly committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    31998c6 View commit details
    Browse the repository at this point in the history

  4. add tools dependency

    @kkoreilly
    kkoreilly committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    97b4d98 View commit details
    Browse the repository at this point in the history

  5. use pkgIdent instead of ipp

    @kkoreilly
    kkoreilly committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    23ca1d5 View commit details
    Browse the repository at this point in the history

  6. use old import method for relative with manual import path; else use … 

    …new x/packages. also found minimal set of Need flags.
    @rcoreilly
    rcoreilly committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    132533f View commit details
    Browse the repository at this point in the history

  7. add comments for new Extract logic

    @kkoreilly
    kkoreilly committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    b61eba6 View commit details
    Browse the repository at this point in the history

  8. only actually need NeedTypes

    @kkoreilly
    kkoreilly committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    3d103b3 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. import generic functions from extracted go code as interpreted code.

    @rcoreilly
    rcoreilly committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    5d17017 View commit details
    Browse the repository at this point in the history

  2. fix extract test

    @rcoreilly
    rcoreilly committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c2ababe View commit details
    Browse the repository at this point in the history

  3. remove D3 test

    @rcoreilly
    rcoreilly committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    1c00252 View commit details
    Browse the repository at this point in the history

  4. fixes for 2 of 4 failing tests: use .Elem() as needed to allow interf… 

    …ace conversion.
    @rcoreilly
    rcoreilly committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    bc586c3 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. fix out-of-scope type checking logic: fixes tests d3, p6; better type… 

    … conversion nil guard
    @rcoreilly
    rcoreilly committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    02afb87 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. fixed a couple of other generics cases, as documented at end of gener… 

    …ic_test.go with additional test cases. hopefully that's the end of it..
    @rcoreilly
    rcoreilly committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    59c7651 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. fix linter issues

    @rcoreilly
    rcoreilly committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    474f9bb View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. gofumpt clean

    @rcoreilly
    rcoreilly committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    ce22916 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into generic-func

    @rcoreilly
    rcoreilly authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    b74ab40 View commit details
    Browse the repository at this point in the history