Add notification description

traccar · Sep 18, 2024 · 6f2b4b4 · 6f2b4b4
1 parent d70becb
commit 6f2b4b4
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/src/common/util/formatter.js b/src/common/util/formatter.js
@@ -137,6 +137,9 @@ export const getBatteryStatus = (batteryLevel) => {
 };
 
 export const formatNotificationTitle = (t, notification, includeId) => {
+  if (notification.description) {
+    return notification.description;
+  }
   let title = t(prefixString('event', notification.type));
   if (notification.type === 'alarm') {
     const alarmString = notification.attributes.alarms;

diff --git a/src/settings/NotificationPage.jsx b/src/settings/NotificationPage.jsx
@@ -9,6 +9,7 @@ import {
   Checkbox,
   FormGroup,
   Button,
+  TextField,
 } from '@mui/material';
 import ExpandMoreIcon from '@mui/icons-material/ExpandMore';
 import { useTranslation, useTranslationKeys } from '../common/components/LocalizationProvider';
@@ -93,7 +94,7 @@ const NotificationPage = () => {
               {item.notificators?.includes('command') && (
                 <SelectField
                   value={item.commandId}
-                  onChange={(event) => setItem({ ...item, commandId: Number(event.target.value) })}
+                  onChange={(e) => setItem({ ...item, commandId: Number(e.target.value) })}
                   endpoint="/api/commands"
                   titleGetter={(it) => it.description}
                   label={t('sharedSavedCommand')}
@@ -112,7 +113,7 @@ const NotificationPage = () => {
                   control={(
                     <Checkbox
                       checked={item.always}
-                      onChange={(event) => setItem({ ...item, always: event.target.checked })}
+                      onChange={(e) => setItem({ ...item, always: e.target.checked })}
                     />
                     )}
                   label={t('notificationAlways')}
@@ -127,9 +128,14 @@ const NotificationPage = () => {
               </Typography>
             </AccordionSummary>
             <AccordionDetails className={classes.details}>
+              <TextField
+                value={item.description || ''}
+                onChange={(e) => setItem({ ...item, description: e.target.value })}
+                label={t('sharedDescription')}
+              />
               <SelectField
                 value={item.calendarId}
-                onChange={(event) => setItem({ ...item, calendarId: Number(event.target.value) })}
+                onChange={(e) => setItem({ ...item, calendarId: Number(e.target.value) })}
                 endpoint="/api/calendars"
                 label={t('sharedCalendar')}
               />

diff --git a/src/settings/NotificationsPage.jsx b/src/settings/NotificationsPage.jsx
@@ -54,6 +54,7 @@ const NotificationsPage = () => {
       <Table className={classes.table}>
         <TableHead>
           <TableRow>
+            <TableCell>{t('sharedDescription')}</TableCell>
             <TableCell>{t('notificationType')}</TableCell>
             <TableCell>{t('notificationAlways')}</TableCell>
             <TableCell>{t('sharedAlarms')}</TableCell>
@@ -64,6 +65,7 @@ const NotificationsPage = () => {
         <TableBody>
           {!loading ? items.filter(filterByKeyword(searchKeyword)).map((item) => (
             <TableRow key={item.id}>
+              <TableCell>{item.description}</TableCell>
               <TableCell>{t(prefixString('event', item.type))}</TableCell>
               <TableCell>{formatBoolean(item.always, t)}</TableCell>
               <TableCell>{formatList('alarm', item.attributes.alarms)}</TableCell>