Update #96
Open
Update #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tananaev
reviewed
Mar 24, 2023
app/src/main/AndroidManifest.xml
Outdated
| @@ -19,10 +18,11 @@ | |||
|
|
|||
| <meta-data | |||
| android:name="com.google.android.geo.API_KEY" | |||
| android:value="AIzaSyAMQYClXhA2tZdfCzu9EK9wUDWtCRQ6Bj0" /> | |||
| android:value="Update_witch_your_google_api_key" /> | |||
| @@ -16,7 +16,6 @@ | |||
| package org.traccar.manager; | |||
|
|
|||
| public class ServiceException extends Exception { | |||
|
|
|||
There was a problem hiding this comment.
Can you please revert the files that only have formatting changes like this.
| @@ -41,9 +39,10 @@ public interface WebService { | |||
| @GET("/api/devices") | |||
| Call<List<Device>> getDevices(); | |||
|
|
|||
| @GET("/api/commandtypes") | |||
| @GET("api/commands/types") | |||
There was a problem hiding this comment.
Keep the leading / for consistency.
| android:layout_height="wrap_content" | ||
| android:layout_marginBottom="2dp" | ||
| android:text="@string/action_click_to_send_command" /> | ||
| <HorizontalScrollView |
There was a problem hiding this comment.
Why are you using HorizontalScrollView her instead of a simple view?
Comment on lines
+1
to
+19
| pluginManagement { | ||
|
|
||
| repositories { | ||
| gradlePluginPortal() | ||
| google() | ||
| mavenCentral() | ||
| } | ||
|
|
||
| } | ||
| dependencyResolutionManagement { | ||
| repositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS) | ||
| repositories { | ||
| google() | ||
| mavenCentral() | ||
| } | ||
|
|
||
| } | ||
|
|
||
| rootProject.name = "native" |
Correcao api key
tananaev
reviewed
Mar 24, 2023
| @@ -0,0 +1,20 @@ | |||
| { | |||
There was a problem hiding this comment.
You should also remove the output and probably add it to the gitignore.
Return non updates files
|
I believe I managed to meet your considerations. |
|
You still have the output checked in, including the APK file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.