Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Configure golangci-lint #770

Merged
merged 5 commits into from
Jun 28, 2024
Merged

🔧 Configure golangci-lint #770

merged 5 commits into from
Jun 28, 2024

Conversation

H1rono
Copy link
Member

@H1rono H1rono commented Jun 28, 2024

#766 (not close)
設定はとりあえず最小

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 0.74074% with 268 lines in your changes missing coverage. Please review.

Project coverage is 25.86%. Comparing base (0189bd8) to head (f870924).
Report is 3 commits behind head on v2.

Files Patch % Lines
router/middleware.go 0.00% 199 Missing ⚠️
service/traq.go 0.00% 36 Missing ⚠️
model/model.go 0.00% 24 Missing ⚠️
main.go 0.00% 3 Missing ⚠️
model/request_impl.go 0.00% 2 Missing ⚠️
model/transaction_impl.go 0.00% 2 Missing ⚠️
service/webhook.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #770      +/-   ##
==========================================
- Coverage   25.87%   25.86%   -0.01%     
==========================================
  Files         148      148              
  Lines       26978    26979       +1     
==========================================
- Hits         6980     6978       -2     
- Misses      19121    19124       +3     
  Partials      877      877              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@H1rono
Copy link
Member Author

H1rono commented Jun 28, 2024

とりあえずmergeするけど、もうちょい設定したいのでcloseはしない

@H1rono H1rono merged commit 564546a into v2 Jun 28, 2024
5 of 7 checks passed
@H1rono H1rono deleted the golangci-lint branch June 28, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant