Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQLCL support in Oracle adapter #136

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

walkabout21
Copy link

@walkabout21 walkabout21 commented May 31, 2023

Add support for sqlcl in Oracle adapter by checking for an executable sql binary and defaulting to sqlplus if it doesn't exist.

@walkabout21
Copy link
Author

@tpope , just checking if you need any revisions on this. Would have like to have included some kind of "opt out" for sqlcl, but not sure how it could be implemented.

@tpope
Copy link
Owner

tpope commented Jun 6, 2023

Seeing this code reminded me, all you need to do to opt in is:

let g:dbext_default_ORA_bin = 'sql'

Given that, I think we can probably leave the default as is? Changing the default would mean that Dadbod and dbext would have different defaults, which isn't the worst thing in the world, but also I'm not sure it's worth it just to save one line of configuration.

@walkabout21
Copy link
Author

That makes sense. I didn't see anything about that in the docs so I could roll back my code revision and just add the opt in config info to the oracle adapter section of the documentation for the PR?

@walkabout21
Copy link
Author

walkabout21 commented Jun 26, 2023

@tpope I rolled back the code change and added a note in the documentation explaining how to override sqlplus as the default binary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants