Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: Change mistaken += to = #855

Merged
merged 1 commit into from
Mar 26, 2024
Merged

configure: Change mistaken += to = #855

merged 1 commit into from
Mar 26, 2024

Conversation

salahcoronya
Copy link
Contributor

The line

AX_CHECK_LINK_FLAG([[-Wl,--gc-sections]], [strip+="y$strip"])

is wrong. The += should be =. So the subsequent test is never true, and chokes on dash because += is a bashism.

Signed-off-by: Christopher Byrne <[email protected]>
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b3aab9) 72.43% compared to head (03bc273) 72.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #855   +/-   ##
=======================================
  Coverage   72.43%   72.43%           
=======================================
  Files          34       34           
  Lines        9773     9773           
=======================================
  Hits         7079     7079           
  Misses       2694     2694           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreasFuchsTPM AndreasFuchsTPM merged commit 3f8d6e4 into tpm2-software:master Mar 26, 2024
12 of 13 checks passed
@AndreasFuchsTPM AndreasFuchsTPM added this to the 1.9.1 milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants